cvs commit: ports/devel/kdesvn Makefile distinfo pkg-plist

[Andrew Pantyukhin]

On 6/15/07, Li-Wen Hsu <lwhsu at freebsd.org> wrote:
> On Fri, Jun 15, 2007 at 19:37:15 +0400, Andrew Pantyukhin wrote:
> > > +.if !defined(NOPORTDOCS)
> > > +DOCSDIR=       ${PREFIX}/share/doc/HTML/en/kdesvn
> > >  .endif
> >
> >  Is there any merit to this DOCSDIR definition being
> >  conditional?
>
> Seems no.  Sometimes I put this in the Makefile:
>
> .if !defined(NOPORTDOCS)
> DOCSDIR=        /some/other/place
> PORTDOCS=       *
> .endif

In spite of what bsd.port.mk says, PORTDOCS can be safely
defined even if NOPORTDOCS is defined. Acting on PORTDOCS
is conditionalized by this line:
.if defined(PORTDOCS) && !defined(NOPORTDOCS)

> Besides, though I don't really care where the review goes. (I am very happy
> with this)  But since some people don't like this.  How about replying the
> commit in private, and maintaining a "Common Mistakes when Porting" list,
> after a number of items collected?  Posting it to ports@ list and put into
> the porter's handbook might be a good idea.  This can get more porters'
> attention, and easier to find.  Sometimes, looking for something in the
> high-traffic mailing list is quite hard.  After all, not everyone read
> every commit message and its reply, but every should read the handbook
> (and read again when it is updated), right?

The thing I hope for is that the guys that are so kindly
watching me right now will later help us do the very thing
you describe - figuring out the most common mistakes and
documenting some best practices to avoid them. I'm afraid
I won't be able to do it all alone.

Moreover, as we've already seen, the pleasant part of the
public resonance contributes invaluable opinions to many
issues.

Thanks!