cvs commit: src/sys/net pfil.h

[Robert Watson]

On Fri, 8 Jun 2007, Andrew Gallatin wrote:

> gallatin    2007-06-08 12:43:26 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/net              pfil.h
>  Log:
>  Correct the definition of PFIL_HOOKED() so that it compares
>  the value of ph_nhooks to zero, not the address.  This removes
>  extranious calls to pfil_run_hooks (and an rw lock) from the
>  network stack's critical path when no pfil hooks are active.

Nice catch. :-)

I've not done a line-by-line KTR trace of all locking in the standard UDP and 
TCP input and output paths in a while, but I suspect such a thing is called 
for before 7.0 goes out the door in order to see what else has slipped in. 
It's generally a highly informative exercise.

Robert N M Watson
Computer Laboratory
University of Cambridge