cvs commit: src/sys/kern kern_kse.c kern_thread.c src/sys/sys proc.h

Attilio Rao attilio at FreeBSD.org
Mon Jul 23 14:52:22 UTC 2007


attilio     2007-07-23 14:52:22 UTC

  FreeBSD src repository

  Modified files:
    sys/kern             kern_kse.c kern_thread.c 
    sys/sys              proc.h 
  Log:
  Actually, KSE kernel bits locking is broken and can lead likely to
  dangerous races.
  Fix this problems adding correct locking for the members of 'struct
  kse_upcall' and other struct proc/struct thread related members.
  For the moment, just leave ku_mflag and ku_flags "lazy" locked.
  While here, cleanup the code removing the function kse_GC() (unused),
  and merging upcall_link(), upcall_unlink(), upcall_stash() in their
  respective callers (static functions, very short and only called in one
  place).
  
  Reported by: pav
  Tested by: pav (on some pointyhat cluster nodes)
  Approved by: jeff
  Approved by: re
  Sponsorized by: NGX Italy (http://www.ngx.it)
  
  Revision  Changes    Path
  1.232     +69 -82    src/sys/kern/kern_kse.c
  1.251     +2 -0      src/sys/kern/kern_thread.c
  1.488     +0 -1      src/sys/sys/proc.h


More information about the cvs-all mailing list