cvs commit: ports/net/haproxy-devel/files haproxy.in haproxy.sh.in

[Doug Barton]

Marcelo Araujo wrote:
> araujo      2007-08-05 20:14:02 UTC
> 
>   FreeBSD ports repository
> 
>   Added files:
>     net/haproxy-devel/files haproxy.in 
>   Removed files:
>     net/haproxy-devel/files haproxy.sh.in 
>   Log:
>   - Forgot the new RC script by last commit!
>   
>   PR:             ports/112934  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=112934
>   Approved by:    pav (portmgr, in mentor's absence)
>   
>   Revision  Changes    Path
>   1.1       +50 -0     ports/net/haproxy-devel/files/haproxy.in (new)
>   1.2       +0 -50     ports/net/haproxy-devel/files/haproxy.sh.in (dead)
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/haproxy-devel/files/haproxy.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/haproxy-devel/files/haproxy.sh.in

Always glad to see a new and improved rc.d script. :)  A few comments,
hopefully to be seen as constructive criticism.

1. You might want to look at the style guide at
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html
for some general tips, particularly about how the default options are
set. The way you do it isn't "wrong," it's just not as efficient as it
could be. Also the load_rc_config line should go above the default
settings.
2. Is there a reason that this script needs BEFORE: DAEMON? From the
pkg-descr it looks like this might be reasonable, I just want to be
sure it's been thought out.
3. PREFIX is subbed out in the required_files= line, but not in the
default flags, FYI. Also, since it looks like those two command line
opts aren't really optional, so you might be better off placing them
in command_args instead.
4. Minor style issue, the sig_gracefulstop variable is probably
overkill, since you only use the value once.
5. Last minor style note, extra_commands is usually placed at the top
of the file near the command to make it easier to see.

I know this is a lot of notes, so I want to make clear that overall
the script is fine, these are just some suggestions to hopefully make
it a little better.

Regards,

Doug

-- 

    This .signature sanitized for your protection