cvs commit: src/usr.bin/touch touch.1 touch.c

[Brian Somers]

On Tue, 10 Apr 2007 16:42:56 +0930
"Greg 'groggy' Lehey" <grog at FreeBSD.org> wrote:

> On Tuesday, 10 April 2007 at  9:00:42 +0200, Dag-Erling Smrgrav wrote:
> > Greg 'groggy' Lehey <grog at FreeBSD.org> writes:
> >> On Monday,  9 April 2007 at 12:16:47 +0200, Dag-Erling Smrgrav wrote:
> >>> The latter part is incorrect and should be reverted.  Furthermore,
> >>> usage() should be static.
> >> Can you give details?
> >
> > usage() should be the way it was before your commit, except that it
> > should be static.
> 
> You mean declared as a static function?  In a program of a single
> file?
> 
> As I said before,
> 
> >> Can you give details?
> 
> Specifically, this doesn't match my recollection of "good practice".
> Where is this behaviour mandated?

Bump WARNS?  Every function should be either prototyped
or declared static (or both).

-- 
Brian Somers                                       <brian at Awfulhak.org>
Don't _EVER_ lose your sense of humour !            <brian at FreeBSD.org>