cvs commit: src/include stdio.h src/lib/libc/sys lseek.2 pathconf.2 src/sys/kern vfs_syscalls.c src/sys/sys filio.h unistd.h

[Pawel Jakub Dawidek]

On Fri, Apr 06, 2007 at 05:11:28PM +0400, Andrey Chernov wrote:
> On Fri, Apr 06, 2007 at 12:35:19PM +0200, Pawel Jakub Dawidek wrote:
> > > > These are just namespace pollution in stdio.h.  stdio (fseek()) doesn't
> > > > support them, and the hack of declaring lseek() in stdio.h should not
> > > > be extended to new interfaces.  If stdio ever supports them, then they
> > > > would need to be declared under a visibility ifdef (not #ifdef self).
> > > 
> > > I agree. They must be implemented in fseek.c code first before adding them 
> > > to stdio.h and ifdefed with proper *_VISIBLE tags in all places.
> > > Perhaps new __CDDL_VISIBLE tag required for it.
> > 
> > This is not CDDL licensed. I'm planning to implement support for
> > SEEK_DATA and SEEK_HOLE for UFS.
> 
> This is not matter of license at all but matter of standards conformance.
> 
> Feel free to invent any other __*_VISIBLE tag to exclude this addition 
> from namespace for programs which may define their own SEEK_DATA etc 
> which is allowed f.e. in POSIX namespace. Look like other __*_VISIBLE tags 
> are implemented and what they does. Default is turn all on.

Ok, can someone help me with this?

> In any case adding them to stdio.h is premature action - I not see yet
> corresponding fseek() code.

I'm looking at removing it from stdio.h.

-- 
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20070406/8771b1fd/attachment.pgp