cvs commit: src/sys/dev/kbdmux kbdmux.c

[Ruslan Ermilov]

On Tue, Sep 19, 2006 at 09:44:01AM -0700, Maksim Yevmenkin wrote:
> Ruslan,
> 
> revision 1.12 does NOT work on sparc64. it causes crash with
> 
> panic: trap: memory address not aligned
> 
I was affraid of something like this, but given that an argument
is 64-bit aligned, I didn't think it would be a real problem.
Can you try removing the (int) casts in front of *(intptr_t *)
and see if it helps?

> i'll try to find which particular ioctl causes it. in the mean time
> reverting everything back to (int *) casting makes everything work.
> 
> btw, other keyboard drivers ukbd(4), atkbd(4) and sunkbd(4) use simple
> cast (int *) and NOT intptr_t.
> 
> thanks,
> max
> 
> On 9/19/06, Ruslan Ermilov <ru at freebsd.org> wrote:
> >ru          2006-09-19 13:03:10 UTC
> >
> >  FreeBSD src repository
> >
> >  Modified files:
> >    sys/dev/kbdmux       kbdmux.c
> >  Log:
> >  Make typecast expressions comply with style(9).
> >
> >  Revision  Changes    Path
> >  1.12      +5 -5      src/sys/dev/kbdmux/kbdmux.c


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20060919/70c4f3d3/attachment.pgp