cvs commit: src/sys/net if.c
sam at errno.com
Thu Nov 30 13:18:40 PST 2006
Scott Long wrote:
> Sam Leffler wrote:
>> Gleb Smirnoff wrote:
>>> glebius 2006-11-30 15:02:01 UTC
>>> FreeBSD src repository
>>> Modified files:
>>> sys/net if.c Log:
>>> The recent issues with em(4) interface has shown that the old 4.4BSD
>>> if_watchdog/if_timer interface doesn't fit modern SMP network
>>> stack design.
>>> Device drivers that need watchdog to monitor their hardware should
>>> implement it theirselves.
>>> Eventually the if_watchdog/if_timer API will be removed. For now,
>>> warn that driver uses it.
>>> Reviewed by: scottl
>> Did I miss a headsup on this? Seems like something you should
>> coordinate with folks so people can convert drivers beforehand. I
>> understand the problem and I see this is just a printf but now we're
>> going to have people asking what's going on.
> I didn't expect Gleb to act so quickly on this, but I'm very glad that
> he did. Sorry it was a suprise. Would it help if he or I added an
> UPDATING entry and a mailing list announcement about it?
Please publicize this with at least a posting to current@ so people do
not start asking questions (well, at least more questions--we know not
everyone will see a posting and/or pay attention).
Converting if_watchdog to callout's is mostly mechanical in the wired
nic drivers. For wireless drivers it is not as straightforward. In
particular I'm a little leary of usb wireless drivers due to layering
and the Giant locking in the usb code. OTOH most of the drivers were
already so broken in this area that it probably doesn't hurt to do
mechanical-like changes now (though I worry people will fire-and-forget
to really fix the issues).
More information about the cvs-all