cvs commit: src/sys/dev/usb ukbd.c usb_quirks.c usb_quirks.h usbdevs

[Ruslan Ermilov]

On Wed, Nov 29, 2006 at 12:12:47AM +0100, Henrik Brix Andersen wrote:
> On Wed, Nov 29, 2006 at 01:49:15AM +0300, Ruslan Ermilov wrote:
> > On Tue, Nov 28, 2006 at 11:26:41PM +0100, Henrik Brix Andersen wrote:
> > > On Wed, Nov 29, 2006 at 01:05:29AM +0300, Ruslan Ermilov wrote:
> > > > Why can't you just check for the defined constant?
> > > 
> > > To clarify: it is a run-time issue, not a compile-time issue. The
> > > application will compile fine regardless of the above patch, but
> > > without the above patch (and with ukbd/uhid loaded) the application
> > > will fail to attach to the device.
> > > 
> > You want to build a port only when you know that the kernel has
> > this fix?
> 
> That is my intention, yes. Otherwise end-users will likely be confused
> as to why the application fails to detect their device.
> 
Though there's a way to set a make variable conditional on the
result of running some external command (e.g., grep(1)), I agree
that using __FreeBSD_version in this case is probably easier.


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20061128/2f825bd4/attachment.pgp