cvs commit: ports/www Makefile

Erwin Lansing erwin at FreeBSD.org
Mon Nov 20 18:42:19 UTC 2006


Marc,

I really can't believe you committed this, there are so many things
wrong with this port, I don't know where to start. You just added an
*exact* copy of an existing port with some added patches in files/ and
called it exactly the same name. The way you forked this port, should
have been done by a repocopy as well, but it's too late for that now.
I am not quite sure what you are trying to achieve with this new port,
but it looks like this could be integrated with the existing
mod_log_sql2 port with OPTIONS or alternatively the new port has to be
redone completely as a slave port.

In future, please don't hesitate to ask if you are unsure of how to do
something.

-erwin

On Mon, Nov 20, 2006 at 06:27:18PM +0000, Erwin Lansing wrote:
> erwin       2006-11-20 18:27:18 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     www                  Makefile 
>   Log:
>   Disconnect mod_log_sql2-dtc from the build to fix INDEX.
>   
>   Hat:            portmgr
>   
>   Revision  Changes    Path
>   1.1608    +1 -1      ports/www/Makefile
> 
> http://cvsweb.FreeBSD.org/ports/www/Makefile.diff?r1=1.1607&r2=1.1608&f=h
> | ===================================================================
> | RCS file: /usr/local/www/cvsroot/FreeBSD/ports/www/Makefile,v
> | retrieving revision 1.1607
> | retrieving revision 1.1608
> | diff -u -p -r1.1607 -r1.1608
> | --- ports/www/Makefile	2006/11/20 06:13:45	1.1607
> | +++ ports/www/Makefile	2006/11/20 18:27:18	1.1608
> | @@ -1,4 +1,4 @@
> | -# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/www/Makefile,v 1.1607 2006/11/20 06:13:45 scrappy Exp $
> | +# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/www/Makefile,v 1.1608 2006/11/20 18:27:18 erwin Exp $
> |  #
> |  
> |      COMMENT = Ports related to the World Wide Web
> | @@ -361,7 +361,7 @@
> |      SUBDIR += mod_log_spread
> |      SUBDIR += mod_log_sql
> |      SUBDIR += mod_log_sql2
> | -    SUBDIR += mod_log_sql2-dtc
> | +#    SUBDIR += mod_log_sql2-dtc
> |      SUBDIR += mod_macro
> |      SUBDIR += mod_macro2
> |      SUBDIR += mod_mp3
-- 
Erwin Lansing                                     http://droso.org
Security is like an onion.          (o_ _o)
It's made up of several layers   \\\_\   /_///    erwin at FreeBSD.org
And it makes you cry.            <____) (____>    erwin at aauug.dk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20061120/36bc50ab/attachment.pgp


More information about the cvs-all mailing list