cvs commit: ports/print/acroread7 Makefile pkg-deinstall pkg-plist.7.0.1 pkg-plist.7.0.5 ports/print/acroread7/files pkg-install.in

[Jean-Yves Lefort]

On Fri, 19 May 2006 15:41:22 +0900 (JST)
Hiroki Sato <hrs at FreeBSD.org> wrote:

> Jean-Yves Lefort <jylefort at FreeBSD.org> wrote
>   in <20060519075844.e1ac8d3b.jylefort at FreeBSD.org>:
> 
> jy> On Fri, 19 May 2006 14:53:05 +0900 (JST)
> jy> Hiroki Sato <hrs at FreeBSD.org> wrote:
> jy>
> jy> > Jean-Yves Lefort <jylefort at FreeBSD.org> wrote
> jy> >   in <20060519073710.2a3a1839.jylefort at FreeBSD.org>:
> jy> >
> jy> > jy> On Fri, 19 May 2006 14:27:45 +0900 (JST)
> jy> > jy> Hiroki Sato <hrs at FreeBSD.org> wrote:
> jy> > jy>
> jy> > jy> > Jean-Yves Lefort <jylefort at FreeBSD.org> wrote
> jy> > jy> >   in <200605190513.k4J5DxTq063125 at repoman.freebsd.org>:
> jy> > jy> >
> jy> > jy> > jy> jylefort    2006-05-19 05:13:59 UTC
> jy> > jy> > jy>
> jy> > jy> > jy>   FreeBSD ports repository
> jy> > jy> > jy>
> jy> > jy> > jy>   Modified files:
> jy> > jy> > jy>     print/acroread7      Makefile pkg-plist.7.0.1 pkg-plist.7.0.5
> jy> > jy> > jy>   Added files:
> jy> > jy> > jy>     print/acroread7      pkg-deinstall
> jy> > jy> > jy>     print/acroread7/files pkg-install.in
> jy> > jy> > jy>   Log:
> jy> > jy> > jy>   - Fix packing list
> jy> > jy> > jy>   - Install a desktop entry
> jy> > jy> > jy>
> jy> > jy> > jy>   PR:             ports/96642
> jy> > jy> > jy>   Submitted by:   jylefort
> jy> > jy> > jy>   Approved by:    maintainer timeout (17 days)
> jy> > jy> >
> jy> > jy> >  This commit prevents multiple localized acroread ports
> jy> > jy> >  from working with each other in a system
> jy> > jy>
> jy> > jy> ?
> jy> >
> jy> >  So, please explain how the pkg-install/pkg-deinstall scripts work
> jy> >  when we install a number of localized acroread ports in a system.
> jy>
> jy> It was explained in the PR...
> jy>
> jy> "Notes:
> jy>   - slave ports handling: the desktop entry and icon are installed
> jy>     when the first acroread port is installed, and deinstalled when the
> jy>     last acroread port is deinstalled"
> 
>  Your patch assumes removal of Adobe/Acrobat7.0 on deinstalling.  It only
>  happens when print/acroreadwrapper is deinstalled.
> 
>  Also, I do not like this sort of change because the license (2.5,
>  specifically) does not allow creating another installer and
>  modifying the installed files.  Because of this, I make this port
>  simply call the installer from Adobe.

With that interpretation the port is also illegal since it's not only
a "new installer", but also "modifies the Software" (through brandelf,
for instance):

"You may not otherwise alter or modify the Software or create a new
installer for the Software."

Can I fix pkg-deinstall by checking if $PKG_PREFIX/Adobe/Acrobat7.0 is
empty after deinstallation?

-- 
Jean-Yves Lefort

jylefort at FreeBSD.org
http://lefort.be.eu.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20060519/52c6e3d9/attachment.pgp