cvs commit: ports/astro/celestia Makefile distinfo pkg-message.gnome pkg-plist ports/astro/celestia/files patch-config.h.in patch-src_celestia_Makefile.in patch-src_celestia_gtkmain.cpp patch-src_celutil_resmanager.h patch-src_celutil_util.h

[Jean-Yves Lefort]

On Thu, 04 May 2006 15:25:52 +0200
Pav Lucistnik <pav at FreeBSD.org> wrote:

> Jean-Yves Lefort píše v čt 04. 05. 2006 v 15:17 +0200:
> > On Thu, 04 May 2006 14:43:19 +0200
> > Pav Lucistnik <pav at FreeBSD.org> wrote:
> > 
> > > Jean-Yves Lefort píše v čt 04. 05. 2006 v 12:38 +0000:
> > > > jylefort    2006-05-04 12:38:37 UTC
> > > > 
> > > >   FreeBSD ports repository
> > > > 
> > > >   Modified files:
> > > >     astro/celestia       Makefile distinfo 
> > > >   Added files:
> > > >     astro/celestia       pkg-message.gnome pkg-plist 
> > > >     astro/celestia/files patch-config.h.in 
> > > >                          patch-src_celestia_Makefile.in 
> > > >                          patch-src_celutil_util.h 
> > > >   Removed files:
> > > >     astro/celestia/files patch-src_celestia_gtkmain.cpp 
> > > >                          patch-src_celutil_resmanager.h 
> > > 
> > > >   - Do not use OPTIONS for the mutually exclusive UI choices, use
> > > 
> > > Your usage of OPTIONS is incorrect. For default on options, you have to
> > > test WITHOUT_* variable. Please refer for more details to
> > > http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html
> > 
> > Why?
> 
> When you bypass OPTIONS completely (using BATCH or PACKAGE_BUILD), no
> OPTIONS related variables are created.
> 
> Your tests must do the "default" thing when no variables were created.
> Otherwise pointyhat packages will have non-default properties.
> 
> At the moment, no WITH_LUA nor WITHOUT_LUA variable is created when
> using BATCH, and your test
> 
> .if WITH_LUA
> 
> will fail. Such package will end without Lua support, even when you
> specified the option to default to "on".

Apparently the handbook is outdated:

$ make -V WITH_LUA

$ make -V WITH_LUA BATCH=yes
true
$ make -V WITH_LUA PACKAGE_BUILDING=yes
true

cf. bsd.port.mk:

.       if defined(PACKAGE_BUILDING) || (defined(BATCH) && !exists(${_OPTIONSFILE}))

-- 
Jean-Yves Lefort

jylefort at FreeBSD.org
http://lefort.be.eu.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20060504/7f430093/attachment.pgp