cvs commit: src/sys/netinet ip_fw2.c

[Christian S.J. Peron]

csjp        2006-01-27 02:39:46 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_6)
    sys/netinet          ip_fw2.c 
  Log:
  MFC revision 1.122
  date: 2006/01/20 03:21:25;  author: csjp;  state: Exp;  lines: +1 -0
  Destroy the dynamic rule zone in the event that we fail to insert the
  initial default rule.
  
  MFC revision 1.123
  date: 2006/01/20 05:35:27;  author: csjp;  state: Exp;  lines: +25 -10
  - Change the return type for init_tables from void to int so we can propagate
    errors from rn_inithead back to the ipfw initialization function.
  - Check return value of rn_inithead for failure, if table allocation has
    failed for any reason, free up any tables we have created and return ENOMEM
  - In ipfw_init check the return value of init_tables and free up any mutexes or
    UMA zones which may have been created.
  - Assert that the supplied table is not NULL before attempting to dereference.
  
  This fixes panics which were a result of invalid memory accesses due to failed
  table allocation. This is an issue mainly because the R_Zalloc function is a
  malloc(M_NOWAIT) wrapper, thus making it possible for allocations to fail.
  
  Found by:       Coverity Prevent (tm)
  Coverity ID:    CID79
  MFC after:      1 week
  
  Revision   Changes    Path
  1.106.2.9  +26 -10    src/sys/netinet/ip_fw2.c