cvs commit: src/sys/kern tty.c

Attilio Rao attilio at freebsd.org
Tue Dec 19 19:16:54 PST 2006


2006/12/19, Martin Blapp <mbr at freebsd.org>:
> mbr         2006-12-19 22:34:33 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/kern             tty.c
>  Log:
>  Giant might have been temporarily dropped while waiting for proctree_lock, allowing for an
>  intervening tty_close() that cleared tp->t_session.

Since proctree_lock is a sx lock which uses 2 condition variables,
they alredy drop Giant (DROP_GIANT()) before sleeping. Are you secure
it is the right thing to do here?

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein


More information about the cvs-all mailing list