cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

Bruce Evans bde at zeta.org.au
Tue Dec 12 16:48:31 PST 2006


On Tue, 12 Dec 2006, Bjoern A. Zeeb wrote:

> On Tue, 12 Dec 2006, Scott Long wrote:
>
>> scottl      2006-12-12 05:11:12 UTC
>> 
>>  FreeBSD src repository
>> 
>>  Modified files:
>>    sys/dev/bge          if_bge.c if_bgereg.h
>>  Log:
>>  Fix support for certain 575x/578x chips.  This consists of the following:
> ...
> this change makes my machine hang completely (even not able to break
> into kernel debugger) by the time the interfaces are setup (upon
> boot after hostnames gets set from rc scripts).
>
> it's a dual cpu amd64 with a tyan K8SE which has 2 bges onboard:
> Broadcom BCM5704 A3, ASIC rev. 0x2003
>
> backing out this one makes it boot again without any problems.

I use the following quick fix for a <Broadcom BCM5701 B5, ASIC rev. 0x105>.

%%%
Index: if_bge.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/bge/if_bge.c,v
retrieving revision 1.159
diff -u -2 -r1.159 if_bge.c
--- if_bge.c	12 Dec 2006 05:11:12 -0000	1.159
+++ if_bge.c	12 Dec 2006 17:17:21 -0000
@@ -2542,5 +2631,4 @@
  			    __FUNCTION__);
  		CSR_WRITE_4(sc, BGE_FASTBOOT_PC, 0x0);
-	}

  	/*
@@ -2550,4 +2638,5 @@
  	 */
  	bge_writemem_ind(sc, BGE_SOFTWARE_GENCOMM, BGE_MAGIC_NUMBER);
+	}

  	reset = BGE_MISCCFG_RESET_CORE_CLOCKS|(65<<1);
%%%

This moves the bge_writemem() into a new new block of code that is
only executed for certain bge_asicrevs.  (BTW, it is confusing that
bge_asicrev != ASIC rev. printed by dmesg.)  The bge_writemem() is new
too and without the above it seems to be associated with nothing.  The
above is in bge_reset().  The hang always occurred for initialization
from /etc/rc.d.  bge_reset() somehow succeeded when called twice before
getting that far.

The patch also some other details that I'm interested in and some style
bugs.  I will report these in private mail.

Bruce


More information about the cvs-all mailing list