cvs commit: src/sys/sys sx.h

Ruslan Ermilov ru at freebsd.org
Wed Aug 30 22:22:46 UTC 2006


On Wed, Aug 30, 2006 at 06:11:40PM -0400, John Baldwin wrote:
> On Wednesday 30 August 2006 16:51, Ruslan Ermilov wrote:
> > On Wed, Aug 30, 2006 at 01:20:32PM -0400, John Baldwin wrote:
> > > On Wednesday 30 August 2006 05:37, Bruce Evans wrote:
> > > > On Tue, 29 Aug 2006, John Baldwin wrote:
> > > > 
> > > > > jhb         2006-08-29 20:36:33 UTC
> > > > >
> > > > >  FreeBSD src repository
> > > > >
> > > > >  Modified files:
> > > > >    sys/sys              sx.h
> > > > >  Log:
> > > > >  The _sx_assert() prototype should exist if either of INVARIANTS or
> > > > >  INVARIANT_SUPPORT is defined so you can build a kernel with
> > > > >  INVARIANT_SUPPORT, but build a module with just INVARIANTS on.
> > > > 
[...]
> No.  The _sx_assert() _function_ is only #ifdef INVARIANT_SUPPORT in 
> kern_sx.c.  However, the _sx_assert() function _prototype_ is used both in 
> kern_sx.c when compiling, but also by consumers of the sx_assert() macro 
> defined in sys/sx.h.  That is, the prototype is needed for both cases, 1 is 
> so kern_sx.c has a prototype for the function it declares, this requires 
> INVARIANT_SUPPORT; 2 is for all the users of sx_assert() in the tree, which 
> map sx_assert() to a call to _sx_assert() if INVARIANTS is defined.
> 
OK, that's right.  Sorry for the noise.


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20060830/13818a79/attachment.pgp


More information about the cvs-all mailing list