cvs commit: src/sys/dev/pccbb pccbb.c

[Wesley Morgan]

On Thu, 13 Apr 2006, Christian Brueffer wrote:

> On Wed, Apr 12, 2006 at 10:33:42PM -0400, Niki Denev wrote:
>> M. Warner Losh wrote:
>>> In message: <20060412212843.GH1258 at haakonia.hitnet.RWTH-Aachen.DE>
>>>             Christian Brueffer <brueffer at FreeBSD.org> writes:
>>> : On Thu, Mar 30, 2006 at 04:25:45AM +0000, Warner Losh wrote:
>>> : > imp         2006-03-30 04:25:45 UTC
>>> : >
>>> : >   FreeBSD src repository
>>> : >
>>> : >   Modified files:
>>> : >     sys/dev/pccbb        pccbb.c
>>> : >   Log:
>>> : >   On some laptops, under very high loads, the socket event register read
>>> : >   in the ISR doesn't read the actual socket event register, but instead
>>> : >   reads garbage (usually 0xffffffff, but other times other things).
>>> : >   This totally violates the PCI spec, but happens rarely enough that a
>>> : >   workaround is in order.  This adds one test when we have a real
>>> : >   interrupt to service (which is very rare), and doesn't affect the
>>> : >   usualy 'nothing to see here' case at all.
>>> : >
>>> : >   Problem reported by many, but sam@ gave me this workaround after
>>> : >   diagnosing the problem.
>>> : >
>>> :
>>> : This breaks pccard/cardbus support on my Thinkpad T41p (confirmed by
>>> : backing this change out).  With this change, I just get an "Interrupt
>>> : storm detected on irq 5; throttling" message.
>>> :
>>> : What kind of debug info can I provide?
>>>
>>> A Thinkpad T41p. :-)
>>>
>>> Failing that, can you set hw.cbb.debug=1 and provide me with the
>>> output.
>>>
>>> Warner
>>
>> CURRENT from Monday here, on ThinkPad X31.
>> I tested only with compact flash memory card, because it is the only
>> that i have now, but on insert i get only this on the console :
>> "Interrupt storm detected on "irq5:"; throttling interrupt source"
>> I've set hw.cbb.debug to 1 before inserting the card but i got nothing more.
>>
>> P.S.: i have the following hw.pci. tunables in boot.conf from a long
>> time ago,
>> i don't know if they can affect this behaviour, but i'm giving them here
>> just in case :
>>
>> hw.pci.do_power_nodriver=3
>> hw.pci.allow_unsupported_io_range=1
>> hw.pci.do_powerstate=1
>>
>
> Good to see that someone can reproduce this.  Does it work again when
> you back this change out?

This commit broke pccard insertion detection for me as well. Backing it 
out restores functionality.


-- 
This .signature sanitized for your protection