cvs commit: src/sys/dev/cp if_cp.c
obrien at FreeBSD.org
Thu Oct 27 00:40:54 PDT 2005
On Mon, Oct 24, 2005 at 12:24:23AM -0700, David O'Brien wrote:
> On Tue, Sep 27, 2005 at 04:57:45PM +0000, Roman Kurakin wrote:
> > rik 2005-09-27 16:57:45 UTC
> > FreeBSD src repository
> > Modified files:
> > sys/dev/cp if_cp.c
> > Log:
> > Restore if_cp.c 1.27
> > ----------------------------
> > revision 1.27
> > date: 2005/09/19 03:10:16; author: imp; state: Exp; lines: +3 -2
> > Make sure that we call if_free(ifp) after bus_teardown_intr. Since we
> > could get an interrupt after we free the ifp, and the interrupt
> > handler depended on the ifp being still alive, this could, in theory,
> > cause a crash. Eliminate this possibility by moving the if_free to
> > after the bus_teardown_intr() call.
> > In fact, this change do nothing for this driver. It is protected from
> > this by cp_destroy variable. This variable also protects driver from
> > initiation of any activity from network stack with disabled intr
> > handler with this change applied.
> You should not have backed out my commit without discussing it with me
> and understanding the reason for the change.
> Do it again and I *will* be taking it Core.
rik, I'm sorry this reads as such an aggressive email. I thought we were in a discussion about the reason of my commit and was surprised to see your commit happened in the middle of what I thought was an on-going thread.
More information about the cvs-all