cvs commit: src/sys/net if_vlan.c

Pawel Jakub Dawidek pjd at FreeBSD.org
Wed Oct 26 12:57:05 PDT 2005


pjd         2005-10-26 19:57:04 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_6_0)
    sys/net              if_vlan.c 
  Log:
  Call if_clone_detach() after vlan_clone_destroy() loop, as if_clone_detach()
  is freeing ifc_units field, which is used in
  vlan_clone_destroy()->ifc_free_unit().
  
  This fixes panic: ifc_free_unit: bit is already cleared
  
  The fix introduces a small race in that a new interface could be created
  between the vlan_clone_destroy() loop and the call to if_clone_detach().
  The race is probably too hard to trigger to be worry about it.
  
  This is not an MFC, because better fix was committed to HEAD.
  We decided to use this fix, as it is a low-risk fix, which fits just fine
  for 6.0 at this stage.
  
  Discussed with: brooks, thompsa
  Approved by:    re (scottl)
  
  Revision      Changes    Path
  1.79.2.4.2.1  +1 -1      src/sys/net/if_vlan.c


More information about the cvs-all mailing list