cvs commit: src/sys/dev/cp if_cp.c

David O'Brien obrien at FreeBSD.org
Mon Oct 24 00:24:24 PDT 2005


On Tue, Sep 27, 2005 at 04:57:45PM +0000, Roman Kurakin wrote:
> rik         2005-09-27 16:57:45 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/cp           if_cp.c 
>   Log:
>   Restore if_cp.c 1.27
>   ----------------------------
>           revision 1.27
>           date: 2005/09/19 03:10:16;  author: imp;  state: Exp;  lines: +3 -2
>           Make sure that we call if_free(ifp) after bus_teardown_intr.  Since we
>           could get an interrupt after we free the ifp, and the interrupt
>           handler depended on the ifp being still alive, this could, in theory,
>           cause a crash.  Eliminate this possibility by moving the if_free to
>           after the bus_teardown_intr() call.
>   
>   In fact, this change do nothing for this driver. It is protected from
>   this by cp_destroy variable. This variable also protects driver from
>   initiation of any activity from network stack with disabled intr
>   handler with this change applied.

You should not have backed out my commit without discussing it with me
and understanding the reason for the change.
Do it again and I *will* be taking it Core.

-- 
-- David  (obrien at FreeBSD.org)


More information about the cvs-all mailing list