cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c

Jung-uk Kim jkim at FreeBSD.org
Mon Oct 17 13:42:40 PDT 2005


On Monday 17 October 2005 03:54 pm, John Baldwin wrote:
> Doing it for each CPU would really bloat the output, and in
> practice I don't think would buy us anything.  Note that the code
> assumes the package topology is uniform as well, not just the
> printfs. :)

:-)

> Probably the messages could be made less ambiguous by splitting it
> into two lines that say something like:
>  Cores per package: 2
>  Logical CPUs per core: 1
>
> Except that each line would only print if it's value was greater
> than 1. Thus, on David's box you would get:
>  Cores per package: 2
>
> On a PIV with HTT would get:
>  Logical CPUs per core: 2
>
> And on the super-spiffy Zueeglecorp CPU, you would get:
>  Cores per package: 4
>  Logical CPUs per core: 4

The patch is attached.  Please review.

Thanks for the suggestions and no thanks for bikeshed,

Jung-uk Kim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: identcpu.diff
Type: text/x-diff
Size: 1496 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20051017/35345a59/identcpu.bin


More information about the cvs-all mailing list