cvs commit: ports/games/galaxyhack Makefile ports/games/galaxyhack/files patch-Makefile

Alexey Dokuchaev danfe at FreeBSD.org
Mon Oct 10 07:10:56 PDT 2005


On Mon, Oct 10, 2005 at 01:27:31PM +0000, Renato Botelho wrote:
> garga       2005-10-10 13:27:31 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     games/galaxyhack     Makefile 
>     games/galaxyhack/files patch-Makefile 
>   Log:
>   o Fix wrong patch in "files" directory and convert DOS to UNIX text files in
>     post-extract.

CR/LF -> LF conversion is somewhat suboptimal: by doing -exec, find(1)
spawns ${REINPLACE_CMD} (and probably ${ECHO_CMD}, but this one is cheap
since it's a shell builtin) on every file it finds.  Correct way would
be to use xargs(1), as mentioned in section ``4.4 Patching'' of Porter's
Handbook.

./danfe


More information about the cvs-all mailing list