cvs commit: src/sys/dev/ata atapi-cd.c

Poul-Henning Kamp phk at phk.freebsd.dk
Mon Oct 10 04:01:53 PDT 2005


In message <34cb7c840510100356t1b93e679v6479afda16277afa at mail.gmail.com>, Peter
 Edwards writes:
>> +> Please see geom_disk.c
>>
>I think an advantage to Poul-Henning's approach is that it reduces
>latency: the I/O can start immediately, rather than requiring all the
>bio's to be allocated first. The very fact that the race condition was
>triggered indicates that the IO devices can overtake the CPU. You
>might waste some time in the failure case, but that's obviously a
>small price to pay for improved performance in the normal run of
>things.

Agreed.

I've started wondering if I should actually put this code in a
function so we don't have to reinvent it all over the place.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.


More information about the cvs-all mailing list