cvs commit: ports/x11-wm/windowmaker/files patch-net_wm_icon
Scott
scottl at samsco.org
Mon Mar 28 05:10:42 PST 2005
On further investigation I think that this is actually due to a bug in
Xlib, not GTK. This band-aid is enough for 5.4, though.
Scott
Doug Barton wrote:
> dougb 2005-03-28 09:13:21 UTC
>
> FreeBSD ports repository
>
> Added files:
> x11-wm/windowmaker/files patch-net_wm_icon
> Log:
> Patch to fix a debilitating problem for amd64 users. To quote Scott:
>
> "While it compiles and seems to start fine, it will crash if you
> start any GTK-based program, including Firefox and Mozilla ...
> GTK populates the NET_WM_ICON X11 property with incorrectly padded
> data, and WindowMaker blindly reads it out and winds up passing
> garbage to some X libraries, which in turn abort the entire process ...
> Fortunately, handling this X11 property is not mandatory as there are
> other more reliable ways to pass icon state through X (and in fact very
> very few other window managers even try this), so it's safe to avoid the
> whole mess by stubbing it out and letting Windowmaker fall back to a
> more reliable method."
>
> I've tested this patch with i386 windowmaker, and haven't noticed any
> differences. I have xterms and various other things doing fancy stuff
> with window and icon titles, so I'm pretty confident that this will
> be safe for users of all ARCH's. It's also possible that it will help
> those users who were having weird QT problems, but I was not able to
> reproduce that problem so I can't say for sure.
>
> Submitted by: scottl
> Approved by: portmgr (krion)
>
> Revision Changes Path
> 1.1 +11 -0 ports/x11-wm/windowmaker/files/patch-net_wm_icon (new)
> _______________________________________________
> cvs-ports at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/cvs-ports
> To unsubscribe, send any mail to "cvs-ports-unsubscribe at freebsd.org"
More information about the cvs-all
mailing list