cvs commit: src/sys/kern kern_thread.c

Poul-Henning Kamp phk at phk.freebsd.dk
Sat Mar 19 03:40:05 PST 2005


In message <423C0A0F.6090409 at freebsd.org>, David Xu writes:
>Poul-Henning Kamp wrote:
>
>>phk         2005-03-19 08:22:13 UTC
>>
>>  FreeBSD src repository
>>
>>  Sleeping is not allowed in uma->fini
>>
>I have not tested if this change will hurt libpthread performance,
>but it is obvious that benifit of uma cache will be reduced by
>this change.

I am aware of that and I don't like it either.

The problem is that the uma_mutex is held over the uma->fini() call
and I'm surprised that we set so tight constraints on these functions
but I did not manage to corner the UMA crew and talk to them about it
yesterday evening.

One obvious solution is to taskq the release of the unit number.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.


More information about the cvs-all mailing list