cvs commit: src/sys/dev/aac aac.c

Scott Long scottl at
Wed Mar 2 12:40:52 PST 2005

David O'Brien wrote:
> On Wed, Mar 02, 2005 at 08:19:11AM -0700, Scott Long wrote:
>>David E. O'Brien wrote:
>>>obrien      2005-03-02 09:13:11 UTC
>>> FreeBSD src repository
>>> Modified files:        (Branch: RELENG_5)
>>>   sys/dev/aac          aac.c 
>>> Log:
>>> MFC: rev 1.102: Put some of the probe messages under bootverbose.
>>> Revision   Changes    Path
>>>  +16 -15    src/sys/dev/aac/aac.c
>>I don't recall there being an 'MFC after' message on the original
>>commit, nor do I recall you contacting the maintainer to see if he
>>wanted this merged.  In fact, I DO NOT WANT IT MERGED.  Thanks.
> It has been discussed several times that our boot messages have grown too
> verbose, and you have taken a position on IRC that they should be
> reduced.  Why should we have HEAD and RELENG_5 diverged in this way?  Why
> as a driver developer would you want less information from branch where
> the development takes place?

The agreement that was discussed publically and privately was that we'd
target this for 6.x, not 5.x.  I wanted the aac messages in 5.x bacause,
coincidentally, knowing the aac firmware is very important right now.

In any case, I think that a lot of what you're doing is very good and
I'm glad that you're doing it.  But you still need to respect the
maintainer relationship that exists on much of the code that you're
touching.  A simple query to the original others of many of these
patches would go a long way to making people more comfortable and
avoiding mistakes.


More information about the cvs-all mailing list