cvs commit: src/sys/kern kern_switch.c sched_4bsd.c

Stephan Uphoff ups at freebsd.org
Fri Jun 10 19:03:47 GMT 2005


On Fri, 2005-06-10 at 12:50, John Baldwin wrote:
> On Jun 9, 2005, at 7:45 PM, Stephan Uphoff wrote:
> 
> > On Thu, 2005-06-09 at 19:28, John Baldwin wrote:
> >> On Jun 9, 2005, at 11:26 AM, Stephan Uphoff wrote:
> >>
> >>> ups         2005-06-09 18:26:31 UTC
> >>>
> >>>   FreeBSD src repository
> >>>
> >>>   Modified files:
> >>>     sys/kern             kern_switch.c sched_4bsd.c
> >>>   Log:
> >>>   Fix some race conditions for pinned threads that may cause them to
> >>> run
> >>>   on the wrong CPU.
> >>>
> >>>   Add IPI support for preempting a thread on another CPU.
> >>>
> >>>   MFC after:3 weeks
> >>
> >> Note that this breaks the compile on non x86 when PREEMPTION isn't on
> >
> > I compiled/tested it also without PREEMPTION on x86.
> > Could you send me the error message?
> 
> I mistyped, I meant when preemption is on.  The Alpha tinderbox is 
> keeling over now due to the missing IPI_PREEMPT.  I can try to add 
> IPI_PREEMPT in next week or so.

Thanks - found it.
This is a LINT only problem.

OK to fix it like this? :

RCS file: /cvsroot/src/sys/conf/NOTES,v
retrieving revision 1.1322
diff -u -r1.1322 NOTES
--- NOTES       9 Jun 2005 18:59:21 -0000       1.1322
+++ NOTES       10 Jun 2005 19:01:55 -0000
@@ -231,7 +231,7 @@
 # WITNESS_SKIPSPIN disables the witness checks on spin mutexes.
 options        PREEMPTION
 options        FULL_PREEMPTION
-options        IPI_PREEMPTION
+#options       IPI_PREEMPTION
 options        MUTEX_DEBUG
 options        WITNESS
 options        WITNESS_KDB




More information about the cvs-all mailing list