cvs commit: src/sys/kern kern_switch.c sched_4bsd.c

John Baldwin john at baldwin.cx
Thu Jun 9 23:26:05 GMT 2005


On Jun 9, 2005, at 12:43 PM, Stephan Uphoff wrote:

> ups         2005-06-09 19:43:08 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/kern             kern_switch.c sched_4bsd.c
>   Log:
>   Lots of whitespace cleanup.
>   Fix for broken if condition.
>
>   Submitted by:   nate@

What was broken about the if test?  The intention was that when 
FULL_PREEMPTION was off, we only preempt if the destination thread is 
an ithread or if the current thread is an idle priority thread.  I 
think you've changed it so that we never preempt if the current thread 
is an idle thread now, which is very bad.  I took out explicit calls to 
mi_switch() in the page zeroing thread in reliance on the behavior that 
we always preempt an idle priority thread.

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org



More information about the cvs-all mailing list