cvs commit: src/sys/pci if_xl.c

[Gleb Smirnoff]

On Thu, Jul 14, 2005 at 08:36:08AM -0400, Andrew Gallatin wrote:
A> Gleb Smirnoff [glebius at FreeBSD.org] wrote:
A> > glebius     2005-07-13 14:06:13 UTC
A> > 
A> >   FreeBSD src repository
A> > 
A> >   Modified files:
A> >     sys/pci              if_xl.c 
A> >   Log:
A> >   NET_LOCK_GIANT() when entering network code.
A> >   
A> 
A> Do other drivers do this?  It looks like at least em, fxp
A> and my out-of-tree commercial driver have the same "bug".

They do. Look at if_ath.c:ath_rx_proc(). This is done in functions
that execute from a separate context - from task queue.
em, fxp and others may not have such functions.

A> I would argue that any fiddling with Giant should go into
A> the various if_input routines instead.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE