cvs commit: src/include netdb.h src/lib/libc/net getaddrinfo.c
phantom at FreeBSD.org.ua
Mon Feb 14 16:04:24 GMT 2005
On Tue, Feb 15, 2005 at 12:56:28AM +0900, Hajimu UMEMOTO wrote:
> >>>>> On Mon, 14 Feb 2005 11:33:12 +0000 (UTC)
> >>>>> Alexey Zelkin <phantom at FreeBSD.org> said:
> phantom> . Convert ai_errlist to simple 'char *' array, and appropriately
> phantom> optimize gai_strerror()
> Why did you do this? Since this departs from KAME's getaddrinfo.c, I
> don't want this change unless there is meaningful advantage.
1. This is optimization.
2. This is preparation to addition of NLS support for gai_strerror()
Actually, since gai_strerror() is exported function and only user
of ai_errlist, would not it be better to move these to separate
source file ? It will make KAME integration for getaddrinfo.c
much easier, IMHO.
/* Alexey Zelkin && Independent Contractor */
/* phantom(at)FreeBSD.org && http://www.FreeBSD.org/java */
/* phantom(at)cris.net && http://www.FreeBSD.org.ua/ */
More information about the cvs-all