cvs commit: ports/shells/bash Makefile

Florent Thoumie flz at FreeBSD.org
Mon Dec 5 02:42:07 PST 2005


Le Lundi 05 décembre 2005 à 01:36 -0800, David O'Brien a écrit :
> On Wed, Nov 30, 2005 at 08:03:19PM +0000, Florent Thoumie wrote:
> > Le Mercredi 30 novembre 2005 à 13:37 -0500, Kris Kennaway a écrit :
> > > On Wed, Nov 30, 2005 at 05:18:46PM +0000, Florent Thoumie wrote:
> > > > Le Mercredi 30 novembre 2005 ?? 16:16 +0000, Alexey Dokuchaev a ??crit :
> > > > > On Wed, Nov 30, 2005 at 03:10:12PM +0000, Florent Thoumie wrote:
> > > > > > flz         2005-11-30 15:10:12 UTC
> > > > > > 
> > > > > >   FreeBSD ports repository
> > > > > > 
> > > > > >   Modified files:
> > > > > >     shells/bash          Makefile 
> > > > > >   Log:
> > > > > >   - Add WANT_STATIC_BASH knob.
> > > > > 
> > > > > WANT_ prefix belongs to bpm's internal namespace; it should not be used
> > > > > this way.
> > > > 
> > > > 	Agreed, Pav made the same notice but :
> > > > 
> > > > 	1) that's not my port and,
> > > 
> > > Don't commit bogus changes, and
> > > 
> > > > 	2) shells/bash2 has the same exact construction.
> > > 
> > > fix bogus changes when you encounter them.
> > 
> > 	I'll send a PR with s/WANT/WITH/ later and will commit the fix
> > 	in two weeks with maintainer timeout.
> 
> *sigh* why all the overhead?  Since you're already in the middle of this
> issue, please make it right for our users and just commit the fixed
> version now.

	I'm fine with people fixing my mistakes, but that's not 
	something I would assume for every maintainer, so I just wanted 
	to ask in the first place.

	Anyway, thanks for answering, I'll commit it in a couple of 
	minutes.

-- 
Florent Thoumie
flz at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: Ceci est une partie de message
	=?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20051205/ef0f0775/attachment.bin


More information about the cvs-all mailing list