cvs commit: src Makefile.inc1

Garance A Drosehn gad at FreeBSD.org
Thu Dec 1 19:38:26 GMT 2005


At 7:27 PM +0200 12/1/05, Ruslan Ermilov wrote:
>On Thu, Dec 01, 2005 at 05:08:56PM +0000, Warner Losh wrote:
>>  imp         2005-12-01 17:08:56 UTC
>>
>>    FreeBSD src repository
>>
>>    Modified files:
>>      .                    Makefile.inc1
>>    Log:
>  >   In make buildenv, spell sh as ${SHELL}.  In this case, we don't
>  >   want to hard code /bin/sh since we're forking it for the user
>  >   to type commands into.  As such, ${SHELL} is the preferred
>  >   thing users type commands into.
>
>Please consider backing it out.  In this case, we want to hard code
>it to "sh" since the stock ~root/.cshrc always resets $PATH, which
>breaks "make buildenv" for root (which most of us use).
>   Testcase: "which cc" from under "make buildenv" shell.

Hmm.  How about:

BUILDENVSHELL?=sh
buildenv:
	@echo Entering world for ${TARGET_ARCH}:${TARGET}
	@cd ${.CURDIR} && env ${WMAKEENV} ${BUILDENVSHELL} || true

-- 
Garance Alistair Drosehn     =      gad at gilead.netel.rpi.edu
Senior Systems Programmer               or   gad at FreeBSD.org
Rensselaer Polytechnic Institute;             Troy, NY;  USA


More information about the cvs-all mailing list