cvs commit: src/usr.sbin/chkgrp chkgrp.8 chkgrp.c

Liam J. Foy liamfoy at sepulcrum.org
Thu Aug 4 13:07:53 GMT 2005


> This change causes NIS /etc/group entries (+ in column one) to be
> flagged in error. There is a PR (bin/82325) open on this with a proposed
> fix, but here is a simpler (almost) one-line version that I'm using:
> 
> Index: chkgrp.c
> ===================================================================
> RCS file: /usr/cvs/FreeBSD/src/usr.sbin/chkgrp/chkgrp.c,v
> retrieving revision 1.9
> diff -u -r1.9 chkgrp.c
> --- chkgrp.c	26 May 2005 10:57:03 -0000	1.9
> +++ chkgrp.c	4 Aug 2005 12:11:03 -0000
> @@ -106,7 +106,8 @@
>  	}
>  
>  	for (cp = f[0] ; *cp ; cp++) {
> -	    if (!isalnum(*cp) && *cp != '.' && *cp != '_' && *cp != '-') {
> +	    if (!isalnum(*cp) && *cp != '.' && *cp != '_' && *cp != '-' &&
> +		    (cp > f[0] || *cp != '+')) {
>  		warnx("%s: line %d: '%c' invalid character", gfn, n, *cp);
>  		e++;
>  	    }
> 
> Maybe someone has the time to commit a fix for this??
> 
> Thanks,
> Bob

Thanks Bob. I'll commit it to dfbsd too.

Cheers,
-- 
		- Liam J. Foy
		liamfoy at sepulcrum.org


More information about the cvs-all mailing list