cvs commit: src/lib/libc/net getproto.c getprotoent.c getprotoname.c netdb_private.h

Daniel Eischen deischen at
Tue Apr 19 12:20:45 PDT 2005

On Wed, 20 Apr 2005, Hajimu UMEMOTO wrote:

> Hi,
> deischen> Stop polluting the namespace.  If the externally visible functions
> deischen> you add are not in a standard and are only for use within libc,
> deischen> they need to be prefixed with "_" or "__".  I haven't paid attention
> deischen> to your other commits in libc, but please go back and fix other
> deischen> occurrences if there are any.  Or make them static if they can
> deischen> be.
> The functions I added are prefixed with `__'.

Look at src/lib/libc/net/getprotoent.c (the only file I examined).
You added getprotoent_r, setprotoent_r, and endprotoent_r.  Even
your commit message says this ;-)  These functions are not in the
POSIX spec as far as I can see.

Dan Eischen

More information about the cvs-all mailing list