cvs commit: src/usr.bin/make cond.c cond.h for.c for.h parse.c parse.h

[Kris Kennaway]

On Mon, Apr 11, 2005 at 11:07:28AM +0200, Harti Brandt wrote:

> KK>I assume you've tested that this doesn't cause problems for anything
> KK>in the ports collection?
> 
> I didn't test all of the ports collection - just a number of ports. But I 
> grepped the ports infrastructure and the ports Makefile* for problematic 
> constructs and found one problem that now shows up (under certain 
> conditions) instead of beeing hidden:
> 
> mail/dspam
> mail/dspam-devel
> 
> both of them use
> 
> . elseif ...
> 
> This has been intepreted by make as a plain .else without any warning up 
> to now. Now it is just ignored when the .if defined (WITH_MYSQL40) ... is 
> false and give an error if it is true. I'll inform the maintainer about 
> this.
> 
> There may be of course ports that use our make to build. In any case the 
> change to the .else and .endif clauses just give a warning so the ports
> maintainer have time to fix this. What could break is the use of 
> .undefFOO but I don't expect many of them.

I really hope this doesn't cause problems, but based on historical
precedent I expect that it will.  In future, please coordinate
troublesome make changes with us (portmgr) so we can test them first
and avoid destabilizing the ports collection for the users.

Kris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20050411/688ad557/attachment.bin