cvs commit: src/sbin/mount mntopts.h mount.8 mount.c src/sbin/mount_std mount_std.8

[Poul-Henning Kamp]

In message <20041130203643.GB20833 at ip.net.ua>, Ruslan Ermilov writes:

>> I tried to find my copy of "Bitmaps for dummies" to check what
>> you're saying but I can't find it right now, still, I'm very sure
>> that you are wrong, I just don't have the book to prove it.
>> 
>> Most operations on MNT_* are "bitwise OR" and a zero is perfectly OK.
>> 
>Well, definitely *not* in sbin/mount/mount.c.

The problem in mount.c is that it terminates the search of optnames[]
if the option is zero.  That would more properly have been fixed by
terminating if the name string was NULL.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.