cvs commit: ports/news/p5-News-Article Makefile pkg-descr

[Yen-Ming Lee]

On Sat, Nov 13, 2004 at 06:33:34PM -0500, Don Croyle wrote:
> Yen-Ming Lee wrote:
> >leeym       2004-11-13 04:57:40 UTC
> >
> >  FreeBSD ports repository
> >
> >  Modified files:
> >    news/p5-News-Article Makefile pkg-descr 
> >  Log:
> >  - remove redundant dependency
> 
> The News::NNTP included in the perl distribution might be suitable, but 
> I would prefer to use the one from the net/p5-Net port.
> 
> You also removed the dependency on PGP::Sign from the 
> security/p5-PGP-Sign port.  I realize that News::Article can be used for 
>  any number of things, but it was originally written with Usenet 
> moderation in mind.  The pgp hooks are there for that purpose and the 
> dependency is called for in the module's README.

Hmm, I tried to parse an article on usenet today, and I don't need PGP since
I don't want GnuPG, which I prefer, to conflict with PGP related stuff.

These two modules don't appear in PREREQ_PM in Makefile.PL, therefore I think that
News::Article should work without these two modules, so I removed it.

How about make it optional dependency which is turned ON by default?
please take a look on the attached patch.

> >  - add WWW in pkg-descr
> http://www.erlenstar.demon.co.uk/perl/ would be a better choice.

Okay, this one would be better. :)

regards,
-- 
Yen-Ming Lee [utf7:+Z05fZWYO] | KeyID:0x5EB52E51 | Taipei, Taiwan
-------------- next part --------------
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/news/p5-News-Article/Makefile,v
retrieving revision 1.18
diff -u -r1.18 Makefile
--- Makefile	13 Nov 2004 04:57:40 -0000	1.18
+++ Makefile	14 Nov 2004 00:17:50 -0000
@@ -16,9 +16,21 @@
 MAINTAINER=	ports at FreeBSD.org
 COMMENT=	Object for handling Usenet articles in mail or news form
 
+BUILD_DEPENDS=	${SITE_PERL}/Net/NNTP.pm:${PORTSDIR}/net/p5-Net
+RUN_DEPENDS=	${SITE_PERL}/Net/NNTP.pm:${PORTSDIR}/net/p5-Net
+
 PERL_CONFIGURE=	yes
 
 MAN3=		News::Article.3 News::AutoReply.3 News::FormArticle.3 \
 		News::FormReply.3
 
-.include <bsd.port.mk>
+OPTIONS=	PGP_SIGN "PGP::Sign support for Usenet moderation" on
+
+.include <bsd.port.pre.mk>
+
+.if !defined(WITHOUT_PGP_SIGN)
+BUILD_DEPENDS+=	${SITE_PERL}/PGP/Sign.pm:${PORTSDIR}/security/p5-PGP-Sign
+RUN_DEPENDS+=	${SITE_PERL}/PGP/Sign.pm:${PORTSDIR}/security/p5-PGP-Sign
+.endif
+
+.include <bsd.port.post.mk>
Index: pkg-descr
===================================================================
RCS file: /home/pcvs/ports/news/p5-News-Article/pkg-descr,v
retrieving revision 1.2
diff -u -r1.2 pkg-descr
--- pkg-descr	13 Nov 2004 04:57:40 -0000	1.2
+++ pkg-descr	14 Nov 2004 00:17:50 -0000
@@ -2,4 +2,4 @@
 from various data sources; various header manipulations, and posting
 via NNTP or mailing via a sendmail-workalike.
 
-WWW: http://search.cpan.org/dist/News-Article/
+WWW: http://www.erlenstar.demon.co.uk/perl/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 305 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20041114/a7e34d06/attachment.bin