cvs commit: src/etc/rc.d mixer

John Baldwin jhb at FreeBSD.org
Wed Mar 31 12:58:59 PST 2004


On Saturday 27 March 2004 04:26 am, Doug Barton wrote:
> dougb       2004/03/27 01:26:22 PST
>
>   FreeBSD src repository
>
>   Modified files:
>     etc/rc.d             mixer
>   Log:
>   A few small cleanups:
>
>   1. Add the shutdown keyword so that the script is run at shutdown time,
>   and the mixer* files are saved.

Huh, it seemed to work in my testing w/o this change.  Maybe I botched 
something.

>   2. Twiddle whitespace.

Style(9) mandates blank lines at the start of functions with no local 
variables, so that's why I did that.

>   3. Remove an unecessary function, and therefore collapse one variable.

Only unnecessary if you don't value abstraction. :)  Now if you want to ever 
change the names of the mixer saved files due to a conflict or some such, you 
have to change it in multiple places rather than just one.  I also did post 
this script for review on @arch before it was committed, btw.

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org


More information about the cvs-all mailing list