cvs commit: ports/security/authpf Makefile

Kris Kennaway kris at obsecurity.org
Wed Mar 31 11:38:30 PST 2004


On Wed, Mar 31, 2004 at 09:42:24AM -0800, Max Laier wrote:
> mlaier      2004/03/31 09:42:24 PST
> 
>   FreeBSD ports repository (src committer)
> 
>   Modified files:
>     security/authpf      Makefile 
>   Log:
>   Fix a long standing typeo in Makfile .if and bump PORTREVISION.
>   
>   PR:             64982
>   Submitted by:   Rik

> |  .if defined(WITH_ALTQ) && (${WITH_ALTQ} == "yes")

FYI, testing for "yes" is non-standard.  The standard behaviour is
just to test for existence of the variable, not value, so WITH_FOO=bar
works just as well as WITH_FOO=yes or even WITH_FOO=no [1].

Kris

[1] At first sight the latter might be confusing, but it's less
confusing to learn up-front than to be confused why 99% of the
thousands of WITH_FOO instances don't respect it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20040331/8ace662b/attachment.bin


More information about the cvs-all mailing list