cvs commit: src/sys/net if_gif.c
rwatson at freebsd.org
Wed Mar 31 06:09:26 PST 2004
On Wed, 31 Mar 2004, Ruslan Ermilov wrote:
> > > Implemented this in the attached patch. Note when testing: setting
> > > net.link.gif.max_nesting too high (>20 on my system) and triggering
> > > the recursion causes the kernel stack exhaustion.
> > Why not just do what OpenBSD does and do actual loop detection? This
> > gets rid of the nesting count hack which isn't really what you want to
> > measure anyway.
> > http://www.openbsd.org/cgi-bin/cvsweb/src/sys/net/if_gif.c.diff?r1=1.18&r2=1.19
> Good idea. I will implement it and repost the updated patch here.
While you're at it, we also need loop detection in if_gre. Make sure to
check the IP- and IPv6-layer pieces of these as well.
Robert N M Watson FreeBSD Core Team, TrustedBSD Projects
robert at fledge.watson.org Senior Research Scientist, McAfee Research
More information about the cvs-all