cvs commit: ports/audio/xmms-imms Makefile distinfo ports/audio/xmms-imms/files patch-vars.mk.in

[Brian F. Feldman]

Kris Kennaway <kris at obsecurity.org> wrote:
> On Mon, Mar 22, 2004 at 08:16:48AM -0800, Brian Feldman wrote:
> 
> > |  -CFLAGS = `xmms-config --cflags` @DEBUG_CFLAGS@ -Wall -fPIC -D_REENTRANT
> > |  +CFLAGS = `xmms-config --cflags` @DEBUG_CFLAGS@ @CFLAGS@ -Wall -fPIC -D_REENTRANT
> > | - CPPFLAGS = ${CFLAGS} -pedantic -fno-rtti
> > | + CXXFLAGS = ${CFLAGS} -pedantic -fno-rtti
> > |  -LDFLAGS = `xmms-config --libs` @LIBS@
> > |  +LDFLAGS = `xmms-config --libs` -lc @LIBS@
> 
> You didn't add this just now, but do you really need to link
> explicitly against -lc?  That seems odd.

I had odd toolchain errors (at least on -STABLE) without it.  You would 
think that missing symbols shouldn't be resolved at link time for a shared 
library, but that's what it was attempting to do without the benefit of the 
symbols found in libc.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green at FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\