cvs commit: ports/lang/gcc34 Makefile

[David O'Brien]

On Sun, Mar 21, 2004 at 11:54:05AM +0100, Gerald Pfeifer wrote:
> On Sat, 20 Mar 2004, David O'Brien wrote:
> > Actually this is a bug in your pkg-plist.  I just tested this with your
> > latest commits (Makefile rev 1.166, pkg-plist rev 1.55).  This patch
> > (which I just committed) makes the existing breakage obvious:
> >
> >   @dirrm libexec/gcc/%%GNU_HOST%%/%%GCC_VER%%
> >  + at dirrm libexec/gcc/%%GNU_HOST%%
> >  + at dirrm libexec/gcc
> >   %%LIBJAVA%%share/java/libgcj-%%GCC_VER%%.jar
> 
> Won't this break if more than gcc3x port has been installed?

Nope.  When one 'pkg_delete' they'll just get a warning that the
directory couldn't be removed.  AFAIK that is the prefered behavior vs.
potentially leaving behind an empty directory.

> (I'll shortly mark them as CONFLICTing, but in the longer term this
> should work.)

IMHO, you should not -- GCC fully supports more than one version
installed at the same time.

 
> > Can we agree to this patch now?
> >
> >       .if ${ARCH} == "amd64"
> >       CONFIGURE_TARGET=      x86_64-portbld-freebsd${OSREL}
> >      -.else
> >      -CONFIGURE_TARGET=      ${ARCH}-portbld-freebsd${OSREL}
> >       .endif
> 
> Sure, iff it survives full testing (including a `make deinstall` that
> really removes all files installed by the port).

Grrr.  you're putting a higher bar on this patch than you've put on your
latest commits.  The test should be no regression from the current state
of the port after committing this diff.  As I mentioned, the problem
you claimed was caused by this patch existed before it.

-- 
-- David  (obrien at FreeBSD.org)