cvs commit: ports/x11-toolkits/py-gtk2 Makefile

[Joe Marcus Clarke]

On Sat, 2004-03-13 at 19:05, Kris Kennaway wrote:
> On Sat, Mar 13, 2004 at 10:01:33AM -0800, Joe Marcus Clarke wrote:
> > marcus      2004/03/13 10:01:33 PST
> > 
> >   FreeBSD ports repository
> > 
> >   Modified files:
> >     x11-toolkits/py-gtk2 Makefile 
> >   Log:
> >   Correct a typo that prevented thread support from being enabled.
> >   
> >   Submitted by:   Davide D'Amico <dave at civetta.gufi.org>
> 
> Why is this necessary?
> 
> > | -LIBC_R!=	/sbin/ldconfig -r | grep "c_r|pthread" || true
> > | +LIBC_R!=	/sbin/ldconfig -r | grep "c_r\|pthread" || true
> > |  .if (${LIBC_R} != "") && !defined(WITHOUT_THREADS)
> > |  CONFIGURE_ARGS+=	--enable-thread
> > |  CFLAGS+=		${PTHREAD_CFLAGS}
> 
> By default, every FreeBSD platform supports threads in one form or
> another (but via the same interface, PTHREAD_{CFLAGS,LIBS}) -- your
> test omits testing for libthr, by the way.  The only way someone will
> have arrived at a system without threads is if they have disabled it
> with make.conf variables, so can't you just test for those if you want
> to support those systems?

I had this conversation with the original maintainer of this port a long
time ago, and there was a reason he did this.  I'll try to hunt down why
this happened, and look for a better way to solve the problem it was
meant to solve.

Joe

> 
> Kris
-- 
Joe Marcus Clarke
FreeBSD GNOME Team	::	gnome at FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20040313/90a46cf2/attachment.bin