cvs commit: src/sys/kern kern_exec.c

Kris Kennaway kris at obsecurity.org
Fri Mar 12 14:24:53 PST 2004


On Fri, Mar 12, 2004 at 02:22:42PM -0800, Kris Kennaway wrote:
> On Sat, Mar 13, 2004 at 12:04:39AM +0200, Ruslan Ermilov wrote:
> > On Fri, Mar 12, 2004 at 01:54:50PM -0800, Kris Kennaway wrote:
> > > On Fri, Mar 12, 2004 at 01:06:20PM -0800, Ruslan Ermilov wrote:
> > > > ru          2004/03/12 13:06:20 PST
> > > > 
> > > >   FreeBSD src repository
> > > > 
> > > >   Modified files:
> > > >     sys/kern             kern_exec.c 
> > > >   Log:
> > > >   Do what the execve(2) manpage says and enforce what a Strictly
> > > >   Conforming POSIX application should do by disallowing the argv
> > > >   argument to be NULL.
> > > >   
> > > >   PR:             kern/33738
> > > >   Submitted by:   Marc Olzheim, Serge van den Boom
> > > >   OK'ed by:       nectar
> > > 
> > > Is this likely to break any third party software (e.g. ports)?  If so,
> > > please bump __FreeBSD_version.
> > > 
> > It'll break only broken software, so I don't think the bump is in order.
> 
> Well, that doesn't follow.  When third party software suddenly stops
> running on FreeBSD, we need a way to predict in advance whether or not
> it will run on a given kernel -- whether the software is "broken" in
> an ideological sense or not.  For example, we need to mark the port
> BROKEN on those versions of FreeBSD so the user doesn't waste their
> time worrying about or reporting a known problem.
> 
> __FreeBSD_version bumps have negligible cost, so if we're both wrong
> and this has no effect, then no harm is done.

It turns out this just happened for the ICC commit, so the only thing
that needs to be done is to document in the Porter's Handbook that the
new version also applies to your change.

Kris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20040312/809a308f/attachment.bin


More information about the cvs-all mailing list