cvs commit: ports/www/mplayer-plugin Makefile

[Kris Kennaway]

On Sat, Mar 06, 2004 at 03:17:40AM -0500, Joe Marcus Clarke wrote:
> On Sat, 2004-03-06 at 03:10, Kris Kennaway wrote:
> > On Fri, Mar 05, 2004 at 11:33:20PM -0800, Joe Marcus Clarke wrote:
> > > marcus      2004/03/05 23:33:20 PST
> > > 
> > >   FreeBSD ports repository
> > > 
> > >   Modified files:
> > >     www/mplayer-plugin   Makefile 
> > >   Log:
> > >   Add firefox support via WITH_MOZILLA=firefox.  Note: this only works for
> > >   mplayer-plugin.  Setting WITH_MOZILLA=firefox will not work with the
> > >   galeon ports.
> > 
> > Shouldn't this be WITH_FIREFOX=yes or similar?  Most WITH_ and
> > WITHOUT_ variables do not care about the value, and giving them
> > special values makes it difficult to use with configuration tools like
> > 'make config'.
> 
> This was done for scaling purposes in the original Mozilla-based ports
> (galeon, galeon2, epiphany).  This way, one can specify the mozilla they
> want to use (be it mozilla, mozilla-devel, and one point mozilla-vendor,
> and now firefox).  It was easier than defining a large number of macros
> then deciding on precedence.

OK, going this way, there is precedence for a MOZILLA_PORT variable
(cf APACHE_PORT, GHOSTSCRIPT_PORT) for choosing one of a number of
equivalent choices.

kris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20040306/8400cc00/attachment.bin