cvs commit: src/sys/dev/sound/pcm mixer.c
jhb at FreeBSD.org
Thu Jun 24 11:55:14 PDT 2004
On Thursday 24 June 2004 02:18 pm, Josef El-Rayes wrote:
> John Baldwin <jhb at FreeBSD.org> wrote:
> > Does this really need to be here considering that with rcNG (on by
> > default on current) and /etc/rc.d/mixer this has no effect?
> Eugene Grosbein requested this (kern/63771) implicitely
> and Cameron Grant decided that it is good to accomplish
> this via kenv variables.
> It literally adds only ~5 lines of code, it does not
> decrease stability but adds a feature, I see
> lots of kernel modules configurated via hints and
> bootloader, why not let pcm be configured via this too.
> Why do we have to force users to use mixer script, which
> is not documented anywhere too.
> I will, of course, remove it, if it is wished, I just
> dont see why anyone would have a problem.
It's more that in its current form it doesn't do anything. :) If you had run
this code on a current box with rcNG you would have found that out before
committing so that a solution could be worked out. As it is now, you could
already achieve the desired functionality by simply muting the channel while
the box was in multiuser and the channel would stay muted across reboots
until you explicitly unmute it.
John Baldwin <jhb at FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve" = http://www.FreeBSD.org
More information about the cvs-all