cvs commit: src/contrib/pf/pfctl pfctl_parser.c

Darren Reed darrenr at hub.freebsd.org
Sat Jun 19 18:40:55 PDT 2004


On Sat, Jun 19, 2004 at 09:58:43AM +0100, Doug Rabson wrote:
> On Saturday 19 June 2004 08:17, David Schultz wrote:
> > On Fri, Jun 18, 2004, Maxime Henrion wrote:
> > > Dag-Erling Sm?rgrav wrote:
> > > > Max Laier <mlaier at FreeBSD.org> writes:
> > > > >   Log:
> > > > >   Fix printing of u_int64_t with a cast to unsigned long long.
> > > >
> > > > The correct fix is to cast it to uintmax_t and print it with %ju.
> > >
> > > Using %llu and a cast to (unsigned long long) is as correct as
> > > using uintmax_t and %ju because the C99 standard says that "long
> > > long" is at least 64-bit wide.  We generally use {u,}intmax_t in
> > > FreeBSD because it works in more cases, but in that case we can't
> > > because OpenBSD doesn't have intmax_t.
> >
> > /me wonders how much backpedaling we'll wind up doing on the
> > uintmax_t casts when someone decides to add uint128_t to gcc
> > and uintmax_t becomes painfully slow on 32-bit arches.  ;-)
> 
> Gcc already has uint128_t. I use it all the time on PS2 and something 
> like it is used on x86 for SSE...

That's nice!  Finally a native type for putting IPv6 addresses in!

Darren


More information about the cvs-all mailing list