cvs commit: src/contrib/pf/pfctl pfctl_parser.c

[David Schultz]

On Fri, Jun 18, 2004, Maxime Henrion wrote:
> Dag-Erling Sm?rgrav wrote:
> > Max Laier <mlaier at FreeBSD.org> writes:
> > >   Log:
> > >   Fix printing of u_int64_t with a cast to unsigned long long.
> > 
> > The correct fix is to cast it to uintmax_t and print it with %ju.
> 
> Using %llu and a cast to (unsigned long long) is as correct as using
> uintmax_t and %ju because the C99 standard says that "long long" is at
> least 64-bit wide.  We generally use {u,}intmax_t in FreeBSD because
> it works in more cases, but in that case we can't because OpenBSD
> doesn't have intmax_t.

/me wonders how much backpedaling we'll wind up doing on the
uintmax_t casts when someone decides to add uint128_t to gcc
and uintmax_t becomes painfully slow on 32-bit arches.  ;-)