cvs commit: ports/net/tcpdump Makefile distinfo ports/net/tcpdump/files pkg-message-base

[Jacques A. Vidrine]

On Tue, Jan 13, 2004 at 09:57:36AM -0800, Bruce M Simpson wrote:
> bms         2004/01/13 09:57:36 PST
> 
>   FreeBSD ports repository (src committer)
> 
>   Modified files:
>     net/tcpdump          Makefile distinfo 
>   Added files:
>     net/tcpdump/files    pkg-message-base 
>   Log:
>   Update tcpdump port to latest beta with fixes for security vulnerabilities
>   in tandem with vendor branch in src tree.
>   Add an option to overwrite the base system tcpdump.
>   
>   PR:             ports/61103
>   Submitted by:   edwin

Ugh, I object to the way that ${PORTREVISION} was used here.  What
happens when the port is modified in a way such that ${PORTREVISION}
must be bumped?

 PORTNAME=      tcpdump
 PORTVERSION=   3.8.1
+PORTREVISION=  351
 CATEGORIES=    net
 MASTER_SITES=  http://www.tcpdump.org/beta/
-DISTNAME=      ${PORTNAME}-${PORTVERSION}-316
+DISTNAME=      ${PORTNAME}-${PORTVERSION}-${PORTREVISION}

Please decouple DISTNAME from PORTREVISION, but please leave
PORTREVISION at its current ridiculously high value (351), because it
cannot go backwards until PORTVERSION changes.

(IMHO, if it was really wished that the package name reflect
tcpdump.org's patch level identifier, then PORTVERSION=3.8.1.351 or
similar should have been used.)

Cheers,
-- 
Jacques Vidrine   NTT/Verio SME      FreeBSD UNIX       Heimdal
nectar at celabo.org jvidrine at verio.net nectar at freebsd.org nectar at kth.se