cvs commit: src/gnu/usr.bin/binutils/gasp Makefile src/gnu/usr.bin/binutils/gdb Makefile src/gnu/usr.bin/cvs/cvs Makefile src/gnu/usr.bin/cvs/lib Makefile src/gnu/usr.bin/cvs/libdiff Makefile src/gnu/usr.bin/diff Makefile src/gnu/usr.bin/grep Makefile

[Ruslan Ermilov]

On Mon, Feb 16, 2004 at 09:38:45PM -0800, Andrey A. Chernov wrote:
> ache        2004/02/16 21:38:45 PST
> 
>   FreeBSD src repository
> 
>   Modified files:
>     gnu/usr.bin/binutils/gasp Makefile 
>     gnu/usr.bin/binutils/gdb Makefile 
>     gnu/usr.bin/cvs/cvs  Makefile 
>     gnu/usr.bin/cvs/lib  Makefile 
>     gnu/usr.bin/cvs/libdiff Makefile 
>     gnu/usr.bin/diff     Makefile 
>     gnu/usr.bin/grep     Makefile 
>   Log:
>   Oops, use -I${DESTDIR}/usr/include/gnu instead of ... /../../include/gnu
>   
>   Revision  Changes    Path
>   1.14      +1 -1      src/gnu/usr.bin/binutils/gasp/Makefile
>   1.75      +1 -1      src/gnu/usr.bin/binutils/gdb/Makefile
>   1.44      +1 -1      src/gnu/usr.bin/cvs/cvs/Makefile
>   1.25      +1 -2      src/gnu/usr.bin/cvs/lib/Makefile
>   1.8       +1 -2      src/gnu/usr.bin/cvs/libdiff/Makefile
>   1.16      +1 -1      src/gnu/usr.bin/diff/Makefile
>   1.28      +1 -1      src/gnu/usr.bin/grep/Makefile
> 
This is bogus.  The correct way would be to fix #include's to
spell ``#include <gnu/regex.h>'', but this will be considered
evil as it will take lot of files off their vendor branches.
What was wrong with ${.CURDIR}/.../include/gnu, except
misspelling the number of ".."'s in some cases?

I've been slowly working towards removing all instances of
-I${DESTDIR}/usr/include/... in the src/ makefiles.  Before
this commit, there were only a few makefiles with
-I${DESTDIR}/usr/include/rpcsvc, but RPC code is known to be
a nightmare to deal with.


Cheers,
-- 
Ruslan Ermilov
FreeBSD committer
ru at FreeBSD.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20040218/99080503/attachment-0001.bin